Skip to content

Some scaffolding #29

Description

Issue by elijahbenizzy
Friday Jun 17, 2022 at 22:48 GMT
Originally opened as stitchfix/hamilton#135


[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

elijahbenizzy included the following code: https://github.com/stitchfix/hamilton/pull/135/commits

Activity

  1. HamiltonRepoMigrationBot commented on Feb 26, 2023

    @HamiltonRepoMigrationBot
    Author

    Comment by elijahbenizzy
    Monday Jun 20, 2022 at 20:04 GMT


    Another TODO -- support data quality for dataframes. Some ideas:

    1. Add a output argument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable
    2. output could also apply to a specific column in extract_columns
    3. Add a schema argument, allowing us to run on a dataframe (E.G. column -> type mapping). Note this is redundant with datatype as well...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions