Skip to content

fix(candlestick/boxplot): resolve base axis correctly when series uses xAxisId/yAxisId #21727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+111 −5
Open

fix(candlestick/boxplot): resolve base axis correctly when series uses xAxisId/yAxisId #21727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/chart/helper/whiskerBoxCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import type SeriesData from '../../data/SeriesData';
import type Axis2D from '../../coord/cartesian/Axis2D';
import { CoordDimensionDefinition } from '../../data/helper/createDimensions';
import { CoordinateSystemClipArea } from '../../coord/CoordinateSystem';
import { SINGLE_REFERRING } from '../../util/model';
import {
SHAPE_CLIP_KIND_FULLY_CLIPPED, SHAPE_CLIP_KIND_NOT_CLIPPED, SHAPE_CLIP_KIND_PARTIALLY_CLIPPED,
ShapeClipKind
Expand Down Expand Up @@ -79,8 +80,8 @@ export class WhiskerBoxCommonMixin<Opts extends CommonOption> {

let ordinalMeta;

const xAxisModel = ecModel.getComponent('xAxis', this.get('xAxisIndex')) as CartesianAxisModel;
const yAxisModel = ecModel.getComponent('yAxis', this.get('yAxisIndex')) as CartesianAxisModel;
const xAxisModel = this.getReferringComponents('xAxis', SINGLE_REFERRING).models[0] as CartesianAxisModel;
const yAxisModel = this.getReferringComponents('yAxis', SINGLE_REFERRING).models[0] as CartesianAxisModel;
const xAxisType = xAxisModel.get('type');
const yAxisType = yAxisModel.get('type');
let addOrdinal;
Expand Down Expand Up @@ -178,9 +179,9 @@ export class WhiskerBoxCommonMixin<Opts extends CommonOption> {
*/
getBaseAxis(): Axis2D {
const dim = this._baseAxisDim;
return (this.ecModel.getComponent(
dim + 'Axis', this.get(dim + 'AxisIndex' as 'xAxisIndex' | 'yAxisIndex')
) as CartesianAxisModel).axis;
return (this.getReferringComponents(
dim + 'Axis', SINGLE_REFERRING
).models[0] as CartesianAxisModel).axis;
}

getWhiskerBoxesLayout() {
Expand Down
105 changes: 105 additions & 0 deletions test/ut/spec/series/whiskerBoxCommon.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.