[fix](scan) Fix adaptive load batch sizing#63245
Open
mrhhsg wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
6e85a65 to
9b2cada
Compare
Member
Author
|
run buildall |
Member
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review summary for PR 63245 at 9b2cada8649f99e29ec94850348ed4efdef50116:
- Scope reviewed: full PR diff against base
97d04001d7ef49a7e10589d242fd16ce8fa0dc6b; the PR changes onlybe/src/exec/scan/file_scanner.cppby adding adaptive batch-size updates before and after varchar/char truncation. - Existing review context: no existing inline review comments or replies were present, so no duplicate concerns were found.
- Correctness checkpoint: no blocking correctness issue found. The predictor is updated after conversion and before truncation, which matches the stated goal of learning from the pre-truncation materialized block; the post-truncation call only records observability counters and does not affect prediction.
- Safety/regression checkpoint: no new error path or ownership/lifetime issue found. The helper methods already guard
_should_run_adaptive_batch_size()and tolerate empty blocks before callingupdate(). - Compatibility checkpoint: no external API, serialization, or persisted data compatibility impact found.
- Testing/validation checkpoint:
git diff --check 97d04001d7ef49a7e10589d242fd16ce8fa0dc6b 9b2cada8649f99e29ec94850348ed4efdef50116passed locally in the runner. I did not run the broader Doris regression suite due to scope/runtime. - User focus: no additional user-provided review focus was specified.
- Repository review instructions: no
AGENTS.mdor repository code-review skill file was present in this checkout, so I applied the explicit review prompt requirements.
Opinion: no critical blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related PR: #63005
Root Cause
The load path initialized adaptive batch sizing but did not update the predictor after converting loaded source blocks. As a result, the reader could keep using the initial small probe size.
Validation
git diff --checkgit diff --cached --check./run-regression-test.sh --run -d unique_with_mow_c_p0 -s test_compact_with_seq2