Skip to content

Unit tests for GenericDaoBase to check the filters with offset and limit - #13849

Open
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:dao-tests-for-filter-limit-offset
Open

Unit tests for GenericDaoBase to check the filters with offset and limit#13849
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:dao-tests-for-filter-limit-offset

Conversation

@sureshanaparti

@sureshanaparti sureshanaparti commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds Unit tests for GenericDaoBase to check the filters with offset and limit.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually executed the unit tests.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.22.2 milestone Aug 11, 2026
@sureshanaparti

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.69%. Comparing base (5328528) to head (515f01c).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #13849   +/-   ##
=========================================
  Coverage     17.69%   17.69%           
  Complexity    15835    15835           
=========================================
  Files          5925     5925           
  Lines        533539   533539           
  Branches      65274    65274           
=========================================
+ Hits          94427    94432    +5     
+ Misses       428435   428430    -5     
  Partials      10677    10677           
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants