Update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent

[sureshanaparti]

Description

This PR update suse15 packaging spec, use qemu-ovmf-x86_64 package instead of edk2-ovmf for agent.

Fixes #13004

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.68%. Comparing base (ddcc0c8) to head (118bb20).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13133      +/-   ##
============================================
- Coverage     17.68%   17.68%   -0.01%     
+ Complexity    15794    15792       -2     
============================================
  Files          5922     5922              
  Lines        533095   533095              
  Branches      65208    65208              
============================================
- Hits          94281    94257      -24     
- Misses       428171   428197      +26     
+ Partials      10643    10641       -2     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.75% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@sureshanaparti
can we just update e8/cloud.spec instead of creating a new one ?

diff --git a/packaging/el8/cloud.spec b/packaging/el8/cloud.spec
index 3dee161bf27..13c0a36cb10 100644
--- a/packaging/el8/cloud.spec
+++ b/packaging/el8/cloud.spec
@@ -117,7 +117,7 @@ Requires: ipset
 Requires: perl
 Requires: rsync
 Requires: cifs-utils
-Requires: edk2-ovmf
+Requires: (edk2-ovmf or qemu-ovmf-x86_64)
 Requires: swtpm
 Requires: (python3-libvirt or python3-libvirt-python)
 Requires: (qemu-img or qemu-tools)

[sureshanaparti]

@sureshanaparti can we just update e8/cloud.spec instead of creating a new one ?

diff --git a/packaging/el8/cloud.spec b/packaging/el8/cloud.spec
index 3dee161bf27..13c0a36cb10 100644
--- a/packaging/el8/cloud.spec
+++ b/packaging/el8/cloud.spec
@@ -117,7 +117,7 @@ Requires: ipset
 Requires: perl
 Requires: rsync
 Requires: cifs-utils
-Requires: edk2-ovmf
+Requires: (edk2-ovmf or qemu-ovmf-x86_64)
 Requires: swtpm
 Requires: (python3-libvirt or python3-libvirt-python)
 Requires: (qemu-img or qemu-tools)

ok @weizhouapache , let me check

[sureshanaparti]

@weizhouapache is it good to have separate spec for suse? otherwise, we've to keep the updating el8 spec for suse variants with 'or'?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17782

[sureshanaparti]

@weizhouapache updated as advised, please check. thanks.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

did not test it

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17783

[weizhouapache]

@blueorangutan test suse15 kvm-suse15

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16056)
Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15
Total time taken: 53629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13133-t16056-kvm-suse15.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_from_iso_uefi_secure	Error	54.61	test_deploy_vm_iso_uefi.py
test_02_deploy_vm_from_iso_uefi_legacy	Error	12.63	test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacy	Error	11.53	test_deploy_vm_iso_uefi.py
test_04_deploy_windows_vm_from_iso_uefi_secure	Error	12.56	test_deploy_vm_iso_uefi.py