Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 69 commits into
base: main
Choose a base branch
from

fix build

4584cb8
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

fix build
4584cb8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 11, 2026 in 5m 51s

Quality Gate failed

Failed conditions
1 Security Hotspot
33.1% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 2141 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 79 to 64, Complexity from 21 to 14, Nesting Level from 5 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gV&open=AZ4Ig9DRLLXNfHHEi1gV&pullRequest=12617

Check warning on line 6897 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9R1LLXNfHHEi1gr&open=AZ4Ig9R1LLXNfHHEi1gr&pullRequest=12617

Check warning on line 889 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gO&open=AZ4Ig9DRLLXNfHHEi1gO&pullRequest=12617

Check failure on line 991 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1if&open=AZ4Ig9bNLLXNfHHEi1if&pullRequest=12617

Check failure on line 689 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iS&open=AZ4Ig9bNLLXNfHHEi1iS&pullRequest=12617

Check warning on line 2513 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9n4LLXNfHHEi1jQ&open=AZ4Ig9n4LLXNfHHEi1jQ&pullRequest=12617

Check warning on line 3475 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hU&open=AZ4Ig9UJLLXNfHHEi1hU&pullRequest=12617

Check failure on line 740 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iV&open=AZ4Ig9bNLLXNfHHEi1iV&pullRequest=12617

Check failure on line 384 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iK&open=AZ4Ig9bNLLXNfHHEi1iK&pullRequest=12617

Check warning on line 554 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hD&open=AZ4Ig9SkLLXNfHHEi1hD&pullRequest=12617

Check warning on line 512 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hC&open=AZ4Ig9SkLLXNfHHEi1hC&pullRequest=12617

Check failure on line 213 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "/dev/" 10 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g0&open=AZ4Ig9SkLLXNfHHEi1g0&pullRequest=12617

Check warning on line 77 in engine/storage/src/test/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelectorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig87pLLXNfHHEi1f4&open=AZ4Ig87pLLXNfHHEi1f4&pullRequest=12617

Check failure on line 1891 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1he&open=AZ4Ig9UJLLXNfHHEi1he&pullRequest=12617

Check failure on line 1327 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gS&open=AZ4Ig9DRLLXNfHHEi1gS&pullRequest=12617

Check warning on line 213 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g6&open=AZ4Ig9SkLLXNfHHEi1g6&pullRequest=12617

Check warning on line 55 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_hostDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1iv&open=AZ4Ig9f_LLXNfHHEi1iv&pullRequest=12617

Check warning on line 716 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hH&open=AZ4Ig9SkLLXNfHHEi1hH&pullRequest=12617

Check failure on line 2885 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9hlLLXNfHHEi1jB&open=AZ4Ig9hlLLXNfHHEi1jB&pullRequest=12617

Check warning on line 367 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volsDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9JYLLXNfHHEi1gW&open=AZ4Ig9JYLLXNfHHEi1gW&pullRequest=12617

Check warning on line 7189 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9YwLLXNfHHEi1hy&open=AZ4Ig9YwLLXNfHHEi1hy&pullRequest=12617

Check failure on line 310 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1i7&open=AZ4Ig9f_LLXNfHHEi1i7&pullRequest=12617

Check warning on line 1162 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hS&open=AZ4Ig9UJLLXNfHHEi1hS&pullRequest=12617

Check failure on line 282 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h_&open=AZ4Ig9a_LLXNfHHEi1h_&pullRequest=12617

Check warning on line 1332 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace charset name argument with StandardCharsets.UTF_8 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hd&open=AZ4Ig9UJLLXNfHHEi1hd&pullRequest=12617
View more details on SonarQubeCloud