GH-50019: [CI][C++] Add fallbacks for std::ranges::[any_of|all_of] on older pre-full-C++20 SDKs#50020
Merged
jonkeane merged 1 commit intoMay 23, 2026
Conversation
Member
Author
|
@github-actions crossbow submit test-r-macos-as-cran |
github-actions
Bot
added
awaiting committer review
|
Revision: 031e3f2 Submitted crossbow builds: ursacomputing/crossbow @ actions-257ddaf8b6
|
Member
|
Could you open an associated issue before we merge this? |
github-actions
Bot
added
awaiting merge
kou
added
awaiting committer review
kou
changed the title
std::ranges::[any_of|all_of] on older pre-full-C++20 SDKsstd::ranges::[any_of|all_of] on older pre-full-C++20 SDKs
Member
|
Ah, I found GH-50019. |
Member
Author
|
Ack, sorry I didn't have the issue number in the title! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7c20b7b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes the macos-CRAN failure in our crossbow jobs.
What changes are included in this PR?
Use the same workaround we have been to define the old(er) approach only when we are on an SDK that doesn't have full C++20 support
Are these changes tested?
Yes, crossbow
Are there any user-facing changes?
No