GH-49785: [C++][FlightRPC][ODBC] Get ODBC tests passing on Linux#49786
Open
justing-bq wants to merge 2 commits into
Open
GH-49785: [C++][FlightRPC][ODBC] Get ODBC tests passing on Linux#49786justing-bq wants to merge 2 commits into
justing-bq wants to merge 2 commits into
Conversation
|
|
github-actions
Bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
justing-bq
force-pushed
the
gh-49785-fix-linux-tests
branch
2 times, most recently
from
e35dfe8 to
9e8272d
Compare
justing-bq
force-pushed
the
gh-49785-fix-linux-tests
branch
from
9e8272d to
0ef857d
Compare
justing-bq
requested review from
assignUser,
jonkeane,
kou,
lidavidm and
raulcd
as code owners
justing-bq
force-pushed
the
gh-49785-fix-linux-tests
branch
from
0ef857d to
3439e98
Compare
Contributor
Author
Member
|
Is the ODBC Linux job failure tracked? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Flight SQL ODBC C++ test suite to pass on Linux by updating platform-specific expectations, selectively disabling known-problematic tests on Linux, and re-enabling the ODBC test target in Linux CI.
Changes:
- Update multiple ODBC tests to reflect Linux/Unix-ODBC vs Windows vs macOS driver-manager behavior (return codes, SQLSTATEs, and reported info strings).
- Disable a subset of metadata-related tests on Linux due to an acknowledged BlockingQueue issue (GH-49702).
- Re-enable
arrow-flight-sql-odbc-testexecution on Linux in CI.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/src/arrow/flight/sql/odbc/tests/type_info_test.cc | Adjust expected SQLGetTypeInfo results for SQL_TYPE_* across Windows vs non-Windows. |
| cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc | Reorder typed tests and disable several table-metadata tests on Linux (GH-49702). |
| cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc | Adjust varbinary byte comparisons and add Linux-specific expectations for some APIs. |
| cpp/src/arrow/flight/sql/odbc/tests/statement_attr_test.cc | Linux-specific SQLSTATE expectation for an unsupported stmt attribute. |
| cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h | Add kErrorState00000 constant for tests expecting a “success” SQLSTATE. |
| cpp/src/arrow/flight/sql/odbc/tests/get_functions_test.cc | Restrict SQLGetFunctions tests to Windows due to Unix driver-manager limitations. |
| cpp/src/arrow/flight/sql/odbc/tests/errors_test.cc | Platform-specific expectations for invalid-handle behavior and SQLSTATE differences. |
| cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc | Disable one info test on Linux and adjust expected SQL_ODBC_VER values. |
| cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc | Add pre-connect fixture and adjust platform-specific behavior for several connection attributes. |
| cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc | Disable column-metadata helpers/tests on Linux (GH-49702) and tighten Unicode column checks. |
| ci/scripts/cpp_test.sh | Stop excluding arrow-flight-sql-odbc-test on Linux. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
This failure is due to a problem with |
github-actions
Bot
added
awaiting committer review
justing-bq
force-pushed
the
gh-49785-fix-linux-tests
branch
from
eb84cd0 to
549d4c2
Compare
Collaborator
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After getting the tests building on Linux, the next step is to get all the tests passing.
Resolves #49785.
What changes are included in this PR?
Miscellaneous fixes.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Depends on #49668 and #49784 before being ready for review.