Point PG19 driver tests at the PG19 image (dev_snapshot_PG19)#2464
Merged
Conversation
The PG19 branch's driver test suites referenced apache/age:dev_snapshot_master -- the master (PG18) snapshot -- instead of the branch's own PG19 image. Each branch self-references its dev_snapshot_PG<N> image on Docker Hub (dev_snapshot_PG19 is published), matching master's use of dev_snapshot_master. Update the three references so the go/nodejs/python (docker compose) and JDBC (testcontainers) driver suites test against PG19: - drivers/docker-compose.yml - drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java - drivers/nodejs/test/index.test.ts (design-note comment) Co-authored-by: Copilot <copilot@github.com> modified: drivers/docker-compose.yml modified: drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java modified: drivers/nodejs/test/index.test.ts
There was a problem hiding this comment.
Pull request overview
Updates the PG19 branch’s driver test infrastructure to run against the branch-appropriate Docker image (apache/age:dev_snapshot_PG19) rather than the master/PG18 snapshot, keeping branch CI/test execution aligned with the intended Postgres major version.
Changes:
- Updated
drivers/docker-compose.ymlto useapache/age:dev_snapshot_PG19. - Updated JDBC Testcontainers setup to pull
apache/age:dev_snapshot_PG19. - Updated a Node.js test design-note comment to reference the PG19 snapshot image.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| drivers/docker-compose.yml | Switches the compose-managed test DB image to dev_snapshot_PG19. |
| drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java | Switches the Testcontainers image reference to dev_snapshot_PG19. |
| drivers/nodejs/test/index.test.ts | Updates documentation comment to match the PG19 CI image tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PG19 branch's driver test suites referenced apache/age:dev_snapshot_master -- the master (PG18) snapshot -- instead of the branch's own PG19 image. Each branch self-references its dev_snapshot_PG image on Docker Hub (dev_snapshot_PG19 is published), matching master's use of dev_snapshot_master.
Update the three references so the go/nodejs/python (docker compose) and JDBC (testcontainers) driver suites test against PG19:
Co-authored-by: Copilot copilot@github.com
modified: drivers/docker-compose.yml
modified: drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java
modified: drivers/nodejs/test/index.test.ts