Don't assert on a timer started during dispatch - #24
Open
nob13 wants to merge 1 commit into
Open
Conversation
Such a timer gets its deadline after now was read, so it can be equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aml_dispatch()readsnowonce, drains what is due, then asserts the earliestremaining deadline is strictly in the future:
aml_start_timer()may run on another thread in between, and computes itsdeadline from a later
aml__gettime_us(). So the invariant is>= now, not> now. A zero timeout collides within the same microsecond and hits it easily.Repro: 2000 zero-timeout timers from a foreign thread against a busy loop aborts
3 of 5 runs before, 0 of 5 after.