Jess/38 fix version - #39
Merged
Merged
Conversation
Collaborator
Author
|
Still investigating web build - in my tests, changelog hasn't displayed on web app. Otherwise across ios, macos and web version and changelog works well. |
Collaborator
Author
Version and changelog working fine on web build - see https://github.com/privacyeng/solidmail/issues/63 @tonypioneer, @gjwgit - This PR is ready for review. Ideally a test on android, windows and linux using a app with a private repo. |
tonypioneer
approved these changes
Sep 10, 2026
tonypioneer
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jesscmoore. All looks good to me.
Collaborator
Author
|
@gjwgit Are you able to test on linux? Any chance of a merge and version_widget pubdev update? |
gjwgit
approved these changes
Sep 14, 2026
gjwgit
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
This supports alternative read of changelog from public webpage (required for private repo apps), fetching latest version not just the topmost version, colours orange if changelog cannot be reached, fetch failures are now not the blue colour
Submitted as a version bump to 1.1.0 as 5 new constructors and a newly exported ChangelogLoader, as resolves the blue version label with no version number or incorrect version numbers if changelog out of order.
It's cackwards compatible. But could be promoted to v2.0.0. If so remove the deprecated
defaultDateparameter.Related Issues
Type of Change
How To Test?
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising