Skip to content

Jess/38 fix version - #39

Merged
gjwgit merged 9 commits into
mainfrom
jess/38_fix_version
Sep 14, 2026
Merged

Jess/38 fix version#39
gjwgit merged 9 commits into
mainfrom
jess/38_fix_version

Conversation

@jesscmoore

@jesscmoore jesscmoore commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

This supports alternative read of changelog from public webpage (required for private repo apps), fetching latest version not just the topmost version, colours orange if changelog cannot be reached, fetch failures are now not the blue colour

Submitted as a version bump to 1.1.0 as 5 new constructors and a newly exported ChangelogLoader, as resolves the blue version label with no version number or incorrect version numbers if changelog out of order.

It's cackwards compatible. But could be promoted to v2.0.0. If so remove the deprecated defaultDate parameter.

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

  • Run podmail with this branch

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore

Copy link
Copy Markdown
Collaborator Author

Still investigating web build - in my tests, changelog hasn't displayed on web app.

Otherwise across ios, macos and web version and changelog works well.

@jesscmoore

Copy link
Copy Markdown
Collaborator Author

Still investigating web build - in my tests, changelog hasn't displayed on web app.

Otherwise across ios, macos and web version and changelog works well.

Version and changelog working fine on web build - see https://github.com/privacyeng/solidmail/issues/63

@tonypioneer, @gjwgit - This PR is ready for review. Ideally a test on android, windows and linux using a app with a private repo.

@jesscmoore
jesscmoore requested a review from gjwgit September 10, 2026 06:21

@tonypioneer tonypioneer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jesscmoore. All looks good to me.

@jesscmoore

Copy link
Copy Markdown
Collaborator Author

@gjwgit Are you able to test on linux? Any chance of a merge and version_widget pubdev update?

@gjwgit
gjwgit merged commit 028da97 into main Sep 14, 2026
22 checks passed
@gjwgit
gjwgit deleted the jess/38_fix_version branch September 14, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants