Tony/553 upload performance - #54
Open
tonypioneer wants to merge 1 commit into
Open
tonypioneer wants to merge 1 commit into
tonypioneer wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the circular import between the DPoP key manager and token generator.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves DPoP signing performance by caching parsed RSA keys and invalidating them during key lifecycle changes.
Changes:
- Caches parsed signing keys.
- Clears cached keys on rotation and logout.
File summaries
| File | Summary |
|---|---|
lib/src/dpop/dpop_token_generator.dart |
Adds signing-key caching. |
lib/src/dpop/dpop_key_manager.dart |
Invalidates the cache; introduces a circular import requiring changes. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import 'package:fast_rsa/fast_rsa.dart'; | ||
| import 'package:logging/logging.dart'; | ||
|
|
||
| import 'package:solid_auth/src/dpop/dpop_token_generator.dart'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
The fixes introduce HTTP connection reuse, remove redundant GET requests, batch encryption-key updates (solidpod), cache DPoP key parsing (solid_auth), and add concurrent reads/writes in HealthPod.
Related Issues
anusii/healthpod#553
Type of Change
How To Test?
Run the analysis.
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising