Skip to content

Av/711 migrate to latest OIDC - #51

Merged
gjwgit merged 2 commits into
devfrom
av/711_migrate_to_latest_oidc
Sep 3, 2026
Merged

gjwgit merged 2 commits into
devfrom
av/711_migrate_to_latest_oidc

Conversation

@anushkavidanage

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

Summary

  • Bump oidc ^0.14.0^4.0.0, oidc_core ^0.16.0^3.0.0, oidc_default_store ^0.6.0^1.0.0 (three major releases: 1.0.0, 2.0.0, 3.0.0/4.0.0). Raises the environment floor to Dart >=3.11.0 / Flutter >=3.41.0, required by the new oidc_darwin plugin (which merges oidc_ios+oidc_macos).
  • Pin initMode: OidcInitMode.blockingValidate in SolidOidcManagerFactory. oidc_core 2.0+ changed init()'s default to cacheFirst. SolidAuthManager.tryRestoreSession() reads currentAuthData synchronously right after init() resolves, so it needs the old guarantee that an expired token is already refreshed by the time init() returns.
  • Stop forwarding SolidOidcConfig.strictJwtVerification to OidcUserManagerSettings - the corresponding constructor parameter no longer exists in oidc_core 1.0+, which removed the fail-open opt-out entirely (ID token signature verification is now unconditionally strict). The field is kept on SolidOidcConfig as a documented no-op so existing call sites don't fail to compile.

Related Issues

anusii/solidpod#711

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Run solid_auth example app and login to any community solid server and check if the auth flow works.

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@gjwgit gjwgit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk review.

@gjwgit
gjwgit merged commit bc9a0b6 into dev Sep 3, 2026
16 of 20 checks passed
@gjwgit
gjwgit deleted the av/711_migrate_to_latest_oidc branch September 3, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants