Newbranch - #7
Open
anuragmaher wants to merge 12 commits into
Open
Conversation
anuragmaher
commented
Jan 17, 2017
|
|
||
| Auth::routes(); | ||
|
|
||
| $test = |
Owner
Author
There was a problem hiding this comment.
[code_sniffer]
- Whitespace found at end of line
anuragmaher
commented
Jan 18, 2017
|
|
||
| use Illuminate\Http\Request; | ||
|
|
||
| class homecontroller{ $th } |
Owner
Author
There was a problem hiding this comment.
[code_sniffer]
- Class name "homecontroller" is not in camel caps format
- Opening brace of a class must be on the line after the definition
- There must not be more than one property declared per statement
- Visibility must be declared on property "$th"
- The closing brace for the class must go on the next line after the body
- Closing brace must be on a line by itself
anuragmaher
commented
Jan 18, 2017
|
|
||
| class homecontroller{ $th } | ||
|
|
||
| class HomeController extends Controller |
Owner
Author
There was a problem hiding this comment.
[code_sniffer]
- Each class must be in a file by itself
anuragmaher
commented
Jan 18, 2017
|
|
||
| class homecontroller{ $th } | ||
|
|
||
| class homecontrollerwa { $th } |
Owner
Author
There was a problem hiding this comment.
[code_sniffer]
- Each class must be in a file by itself
- Class name "homecontrollerwa" is not in camel caps format
- Opening brace of a class must be on the line after the definition
- The closing brace for the class must go on the next line after the body
- Closing brace must be on a line by itself
anuragmaher
commented
Jan 18, 2017
| class homecontrollerwa { $th } | ||
|
|
||
|
|
||
| class HomeController extends Controller |
Owner
Author
There was a problem hiding this comment.
[code_sniffer]
- Each class must be in a file by itself
Owner
Author
|
Click here if you want to create code_sniffer's auto-correct Pull Request See the documentation if you want to get more information about auto-correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.