shopping cards: sanitize model-authored text before it reaches the host - #9
Open
vishkaty wants to merge 1 commit into
Open
shopping cards: sanitize model-authored text before it reaches the host#9vishkaty wants to merge 1 commit into
vishkaty wants to merge 1 commit into
Conversation
A pick's `reason` on the products card is the model's own text, but it travels to the host's renderer in the same payload as third-party records. It went through unsanitized: a fence marker or an invisible character the model copied from a listing reached the page intact. `enrich_products` and the streaming partial now pass the reason through the storefront fence's `sanitize_text`, the same treatment every tool result gets. Found by a conformance statement over the executor (HS-S-06).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pick's
reasonon the products card is the model's own text, but it travels tothe host's renderer in the same payload as third-party records. It went through
unsanitized: a fence marker or an invisible character the model copied from a
listing reached the page intact.
enrich_productsand the streaming partial now pass the reason through thestorefront fence's
sanitize_text, the same treatment every tool result gets.Found by a conformance statement over the executor (HS-S-06).
Found by running a conformance statement against the reference at
fd4d592; the test in this change fails without the fix and passes with it. The full suite,ruff check,ruff format --checkandscripts/check.pyare clean on this branch.