shopping executor: validate the cart quantity as an argument, not an outage - #8
Open
vishkaty wants to merge 1 commit into
Open
Conversation
…outage
`_add_to_cart` and `_update_cart_item` did `int(tool_input.get("quantity") or 1)`. A
string such as "abc" or a list raised inside the handler, so the model was told
add_to_cart was temporarily unavailable and the log carried a traceback, while a
float was truncated and None became 1 silently.
The quantity now goes through `parse_argument` like every other model argument
(`CartQuantity`), so a value the schema would reject is reported as invalid
arguments naming the field, a numeric string is coerced, and None still means one.
Found by a conformance statement over the executor (EX-S-12).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_add_to_cartand_update_cart_itemdidint(tool_input.get("quantity") or 1). Astring such as "abc" or a list raised inside the handler, so the model was told
add_to_cart was temporarily unavailable and the log carried a traceback, while a
float was truncated and None became 1 silently.
The quantity now goes through
parse_argumentlike every other model argument(
CartQuantity), so a value the schema would reject is reported as invalidarguments naming the field, a numeric string is coerced, and None still means one.
Found by a conformance statement over the executor (EX-S-12).
Found by running a conformance statement against the reference at
fd4d592; the test in this change fails without the fix and passes with it. The full suite,ruff check,ruff format --checkandscripts/check.pyare clean on this branch.