retail cart: refuse in the contract's terms; a quantity under one removes the line - #14
Open
vishkaty wants to merge 1 commit into
Open
Conversation
…oves the line `add_to_cart` raised `KeyError` for an unknown id or a family, which the executor reports as an outage; it now raises `Unavailable`, naming the sellable variants for a family, as the contract describes. `SessionCarts.set_quantity` stored a line at quantity 0 or below (`CartItem` requires at least one); it now removes the line, which is also what the ticketing example does with a hold at zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_to_cartraisedKeyErrorfor an unknown id or a family, which the executorreports as an outage; it now raises
Unavailable, naming the sellable variantsfor a family, as the contract describes.
SessionCarts.set_quantitystored a lineat quantity 0 or below (
CartItemrequires at least one); it now removes the line,which is also what the ticketing example does with a hold at zero.
Found by running a conformance statement against the reference at
fd4d592; the test in this change fails without the fix and passes with it. The full suite,ruff check,ruff format --checkandscripts/check.pyare clean on this branch.