Repository navigation
fix(progress): [sync] allow overriding SVG accessibility semantics - #95
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77764f42af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let stackPtg = 0 | ||
| return ( | ||
| <svg | ||
| role="presentation" |
There was a problem hiding this comment.
When a TypeScript/TSX consumer tries to use the new behavior with <Line role="progressbar" aria-valuenow={50} /> (and likewise for Circle), compilation fails because the exported ProgressProps in packages/progress/src/interface.ts does not include role, ARIA attributes, or the relevant Vue SVGAttributes. The test bypasses this public typing through test-utils' attrs, so the runtime behavior passes while normal typed consumers cannot use it without a cast or suppression; extend the public props with the supported SVG accessibility attributes.
Useful? React with 👍 / 👎.
Summary
Synchronized from upstream react-component/progress.
d25eac82c4ffdebc65b9fc674b4c545b4a29f2f4Generated by RepoSync Hub.