fix(desktop): declare minimum Rust version 1.88#23610
Open
rubencu wants to merge 1 commit intoanomalyco:devfrom
Open
fix(desktop): declare minimum Rust version 1.88#23610rubencu wants to merge 1 commit intoanomalyco:devfrom
rubencu wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
7b4b136 to
0a4a53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23611
Type of change
What does this PR do?
This declares the desktop crate's minimum Rust version as
1.88inpackages/desktop/src-tauri/Cargo.tomland documents that requirement in the desktop README.The desktop build already needs a newer compiler than
1.85.1, but without a crate-level minimum it fails with dependency-level errors instead of a direct Cargo message that the desktop crate itself requires a newer Rust toolchain.How did you verify your code works?
cargo +stable checkinpackages/desktop/src-taurinow fails with a directopencode-desktop requires rustc 1.88error onrustc 1.85.1cargo +1.88.0 checkinpackages/desktop/src-taurisucceedsScreenshots / recordings
Not a UI change.
Checklist