Skip to content

fix(desktop): declare minimum Rust version 1.88#23610

Open
rubencu wants to merge 1 commit intoanomalyco:devfrom
rubencu:codex/pin-rust-toolchain-1-88
Open

fix(desktop): declare minimum Rust version 1.88#23610
rubencu wants to merge 1 commit intoanomalyco:devfrom
rubencu:codex/pin-rust-toolchain-1-88

Conversation

@rubencu
Copy link
Copy Markdown

@rubencu rubencu commented Apr 21, 2026

Issue for this PR

Closes #23611

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This declares the desktop crate's minimum Rust version as 1.88 in packages/desktop/src-tauri/Cargo.toml and documents that requirement in the desktop README.

The desktop build already needs a newer compiler than 1.85.1, but without a crate-level minimum it fails with dependency-level errors instead of a direct Cargo message that the desktop crate itself requires a newer Rust toolchain.

How did you verify your code works?

  • cargo +stable check in packages/desktop/src-tauri now fails with a direct opencode-desktop requires rustc 1.88 error on rustc 1.85.1
  • cargo +1.88.0 check in packages/desktop/src-tauri succeeds
  • repo typecheck passed during commit/push

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey! Your PR title [codex] pin desktop Rust toolchain to 1.88.0 doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@rubencu rubencu changed the title [codex] pin desktop Rust toolchain to 1.88.0 fix(desktop): pin Rust toolchain to 1.88.0 Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@rubencu rubencu changed the title fix(desktop): pin Rust toolchain to 1.88.0 fix(desktop): declare minimum Rust version 1.88 Apr 21, 2026
@github-actions github-actions bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@rubencu rubencu force-pushed the codex/pin-rust-toolchain-1-88 branch from 7b4b136 to 0a4a53e Compare April 21, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop crate does not declare its minimum Rust version

1 participant