fix: emit completed assistant chat messages#23591
Open
michael-schienbein-fhr wants to merge 2 commits intoanomalyco:devfrom
Open
fix: emit completed assistant chat messages#23591michael-schienbein-fhr wants to merge 2 commits intoanomalyco:devfrom
michael-schienbein-fhr wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22831
Type of change
What does this PR do?
chat.messagealready exposes populatedpartsfor user messages, but currentdevnever emits a completed assistantchat.message. That leaves plugin authors with an asymmetric hook: they can observe finalized user messages but not finalized assistant messages through the same stable API.This change emits one completed
chat.messagefor assistant messages during processor cleanup, after the assistant message and its parts have been finalized. I also widened the plugin hook type fromUserMessagetoMessageso the hook matches what runtime code now delivers.I kept the change small on purpose:
chat.messagepathThe fix works because the processor already has the finalized assistant message id and can read the final stored parts at cleanup time. Emitting the hook there gives plugins the same completed-message shape they already get for user messages.
How did you verify your code works?
bun test --timeout 30000 test/session/processor-effect.test.ts test/session/prompt-effect.test.tsbun run typecheckorigin/devwithExpected length: 1 / Received length: 0Screenshots / recordings
Not a UI change.
Checklist