fix(opencode): incorrect light mode detection in terminals that misreport CSI mode 997#23564
Open
GuillenSanti wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): incorrect light mode detection in terminals that misreport CSI mode 997#23564GuillenSanti wants to merge 1 commit intoanomalyco:devfrom
GuillenSanti wants to merge 1 commit intoanomalyco:devfrom
Conversation
…eport CSI mode 997 by cross-checking against the actual OSC background color luminance
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20926
Type of change
What does this PR do?
Ghostty (and potentially other terminals) responds to CSI mode 997 with "light" even when the actual terminal background is dark (
#000000). Since@opentui/coregives CSI priority over OSC, the correct background color inference is discarded and OpenCode renders in light mode.I traced the issue by logging the renderer internals after
waitForThemeModeresolves:CSI says "light" but the real background is black — a clear contradiction. This happens even with
window-theme = darkexplicitly set in the Ghostty config, so it's not a user misconfiguration.The fix adds a
resolveThemeMode()function that cross-checks the CSI result against the actual OSC 10/11 background luminance (using the same weighted brightness formula as@opentui/core). When they disagree, the objective color measurement wins.The function is a no-op when:
How did you verify your code works?
bun run devin Ghostty withbackground=#000000→ correctly renders in dark mode (was light before)background=#ffffff→ correctly renders in light mode (not forced dark)bun typecheckpasses across all packagesScreenshots / recordings
N/A — terminal-only change, behavior verified interactively.
Checklist