fix(opencode): validate clipboard content type on Linux#23552
Open
h0wdee wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): validate clipboard content type on Linux#23552h0wdee wants to merge 1 commit intoanomalyco:devfrom
h0wdee wants to merge 1 commit intoanomalyco:devfrom
Conversation
On Linux, xclip/wl-paste output raw bytes even when clipboard contains text (not an image). The code only checked byteLength > 0, so text was incorrectly labeled as image/png and sent to the model, which failed with 'could not process image'. Use existing sniffAttachmentMime() to validate PNG magic bytes before returning clipboard content as an image. Fixes anomalyco#23458
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
However, #14552 appears to be a broader feature improvement for clipboard paste and drag-and-drop, while #23552 is a specific bug fix for validating mime types. They likely complement each other but are addressing different aspects of the clipboard functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23458
Type of change
What does this PR do?
On Linux,
xclip -selection clipboard -t image/png -ooutputs raw bytes even when clipboard contains text (not an image). The code only checkedbyteLength > 0, so text like¯\_(ツ)_/¯was incorrectly labeled asimage/pngand sent to the model, which failed with "could not process image".This fix uses the existing
sniffAttachmentMime()function to validate PNG magic bytes before treating clipboard content as an image. This is the same pattern used in thereadtool.How did you verify your code works?
echo '¯\_(ツ)_/¯' | xclip -selection cScreenshots / recordings
N/A - not a UI change
Checklist