fix: reread local skill files when using skills#23529
Open
remorses wants to merge 1 commit intoanomalyco:devfrom
Open
fix: reread local skill files when using skills#23529remorses wants to merge 1 commit intoanomalyco:devfrom
remorses wants to merge 1 commit intoanomalyco:devfrom
Conversation
Refresh skill content from the current SKILL.md file when the skill tool or skill-backed slash commands load a local skill. This keeps edited local skills in sync without changing the broader discovery cache behavior. Session: ses_255d95f8dffeQnYDq0H6U0KCqb
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potentially related PR: PR #19136: fix(skill): invalidate skill cache when SKILL.md files change on disk This PR appears related as it also addresses the issue of skill cache invalidation when SKILL.md files change. Both PRs (#23529 and #19136) are tackling similar cache-related problems with local skill files, though they may approach the solution differently (PR #23529 rereads on load, while #19136 invalidates when files change on disk). |
remorses
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19050
Type of change
What does this PR do?
Local skills were serving stale content because the cached markdown body was reused after
SKILL.mdchanged.This rereads the local
SKILL.mdfile when the skill tool or a skill-backed slash command loads the skill, and falls back to the cached content if parsing fails.How did you verify your code works?
bun typecheckinpackages/opencodeScreenshots / recordings
Not applicable.
Checklist