refactor(desktop-electron): enable contextIsolation and sandbox#23523
Open
Brendonovich wants to merge 1 commit intodevfrom
Open
refactor(desktop-electron): enable contextIsolation and sandbox#23523Brendonovich wants to merge 1 commit intodevfrom
Brendonovich wants to merge 1 commit intodevfrom
Conversation
…ve injectGlobals pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the Electron desktop app to use proper security practices by enabling
contextIsolationandsandboxon BrowserWindows, and removes theinjectGlobalsanti-pattern.Changes
contextIsolation: true,nodeIntegration: false, andsandbox: trueon all BrowserWindowsinjectGlobals(which usedexecuteJavaScriptto pollutewindow) with proper IPC handlers:getWindowConfig— returns{ updaterEnabled }consumeInitialDeepLinks— returns pending deep links at startup.jsinstead of.mjs) to work with sandboxed rendererwindow.apiinstead ofwindow.__OPENCODE__Motivation
The previous approach disabled Electron's security model (
sandbox: false,contextIsolation: false) and injected globals viaexecuteJavaScript. This refactor aligns with Electron security best practices while preserving all existing functionality.