Repository navigation
fix(drive): match current compaction prompt in compact-admission - #118
Open
kitlangton wants to merge 1 commit into
Open
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
All five
compact-admission.tscases (ordered,coalesce,consumed,cancelled, androllback) fail on current OpenCode V2 witherror: timed out waiting for settled compactions. OpenCode PRanomalyco/opencode#48058updatedSessionCompaction.buildPromptfrom"Summarize only the history shown."to"Summarize only what the user and the assistant said and did.", so the fake model no longer matches compaction requests, returns a plain marker reply (CA_*_DONE) lacking any##section heading, and causes each compaction to settle ascompaction.failed("Compaction summary did not match the required template").Closes #106
What Changes
"Summarize only the history shown"(OpenCode PR #46751)CA_*_DONE, fail the##heading check after the nudge retry, and time out waiting forcompleted"Summarize only the history shown"(#46751) or"Summarize only what the user and the assistant"(#48058)##-sectionedcompactionSummaryand all five admission cases passScope
Updates
packages/drive/test/manual/tui-regressions/compact-admission.tsandpackages/drive/test/manual/tui-regressions/README.mdonly. Compaction admission behavior in OpenCode V2 (PR #45973) is unchanged and passes all five invariants without server or TUI modifications.Verification
Verified on Linux against OpenCode
origin/v2(903ec2bb35):orderedfailed attimed out waiting for settled compactionswithcompaction.failed("Compaction summary did not match the required template") instate-machine-failure.json.{ordered, coalesce, consumed, cancelled, rollback} × {70, 120}columns plus the default 100-columnorderedrun returnedverdict: "pass"(11/11 total). Note: verified on Linux (kitbox); Linux proof does not establish macOS-specific behavior.bun run check,drive check, Vitest (38 files, 277 tests), and CLI integration tests (62 tests) all pass.