Skip to content

fix: align default language directions with CLDR - #187

Open
dpkass wants to merge 1 commit into
annexare:mainfrom
dpkass:fix/default-language-directions
Open

dpkass wants to merge 1 commit into
annexare:mainfrom
dpkass:fix/default-language-directions

Conversation

@dpkass

@dpkass dpkass commented Sep 22, 2026

Copy link
Copy Markdown

The rtl flags for Hausa, Kurdish, Sindhi, and Uyghur disagree with the current default direction of their bare language tags. This aligns them with CLDR likely subtags, matching the algorithm used by Intl.Locale#getTextInfo().

This treats rtl as the direction of the likely/default script for an ISO 639-1 tag. Explicit alternative scripts such as ha-Arab and ku-Arab remain outside the language-only data model.

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
@dpkass
dpkass requested a review from dmythro as a code owner September 22, 2026 11:17
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 73af9880-a37a-4350-9b61-31cc8e072b4c

📥 Commits

Reviewing files that changed from the base of the PR and between 1c39332 and 3c2d634.

📒 Files selected for processing (1)
  • packages/countries/src/data/languages.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The exported languages map updates RTL metadata. Hausa and Kurdish no longer include rtl: 1. Sindhi and Uyghur now include rtl: 1.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3c2d6

This updates default text-direction metadata for four languages and is mergeable with no concrete production risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: aligning default language direction metadata with CLDR.
Description check ✅ Passed The description explains the data changes, defines the rtl behavior, identifies the affected languages, and links to the CLDR and Intl.Locale#getTextInfo() sources. No issue reference is required …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the language chart,
Hausa and Kurdish make a start.
Sindhi turns right-to-left with grace,
Uyghur joins the marked-up place.
Four small flags now point the way.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant