Improved handling of value type containers in foreach - #94
Merged
Merged
Conversation
Owner
|
Thanks a lot for providing this fix. It will save me time to investigate on my own. I'll do a more detailed review and testing on my own before I merge it, but at a quick glance on what you've done it does look to be correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time digging into fixing #92. Since I haven't looked that much at the VM and bytecode for angelscript I might be missing something, but it fixes my case and doesn't break any other at least. And the VM looks pretty standard tbh.
To summarize it and my assumptions:
Does this look correct?