dictionary.get will edit value when passing int instead of int64

[Fort-TM]

Discovered while coding for Openplanet. When running code like this

dictionary MyDictionary;

void Main() {
	int value = -1;
	bool found = MyDictionary.Get("MyKey", value);

	print("Found: " + found);
	print("Value: " + value);
}

The value returned will be edited sometimes

[   ScriptRuntime] [  LOG] [23:13:14] [Test]  Found: false
[   ScriptRuntime] [  LOG] [23:13:14] [Test]  Value: -1255002180
[   ScriptRuntime] [  LOG] [23:13:16] [Test]  Found: false
[   ScriptRuntime] [  LOG] [23:13:16] [Test]  Value: -2083188824

This doesn't happen when using int64 instead, but I'm reporting it just in case. Feel free to close if this is out of scope 👍

[anjo76]

Thanks. I'll investigate.

I suspect it is because the &out value is not set, so you get whatever is in the memory at the location at the time of execution.

[Mikk155]

I wouldn't blame dictionary.

dictionary data;

void Set( const string&in key, int value )
{
    data[ key ] = value;
}

bool Get( const string&in key, int&out value )
{
    if( data.exists( key ) && data.get( key, value ) )
        return true;
    return false;
}

int FirstOrDefault( const string&in key, int value )
{
    if( !Get( key, value ) )
        Set( key, value );
    return value;
}

// Workaround i did since "value" gets a weird behaviour
int FirstOrDefaultAlt( const string&in key, int value )
{
    int temp = value;
    if( !Get( key, temp ) )
    {
        Set( key, value );
        return value;
    }
    return temp;
}

void main()
{
    g_Game.AlertMessage( at_console, "FirstOrDefault(5) -> %1\n", FirstOrDefault( "FirstOrDefault", 5) );
    g_Game.AlertMessage( at_console, "FirstOrDefaultAlt(5) -> %1\n", FirstOrDefaultAlt( "FirstOrDefaultAlt", 5) );
    g_Game.AlertMessage( at_console, "FirstOrDefaultAlt(10) -> %1\n", FirstOrDefaultAlt( "FirstOrDefaultAlt", 10) );
}

Output:

FirstOrDefault(5) -> 0
FirstOrDefaultAlt(5) -> 5
FirstOrDefaultAlt(10) -> 5

The FirstOrDefaultAlt is ok though you can see FirstOrDefault returning "0" when it should've been 5 since i am also using dictionary.exists at my "Get" method before trying to use dictionary.get so most likely its a general problem with &out rather than dictionary. this also happens with uint as far as i recall. haven't tried with other types but if i am not wrong it is all fine with bool