feat(cli): add convert timeout for one/one-detailed (#366) - #420
Open
Supermonters wants to merge 1 commit into
Open
Supermonters wants to merge 1 commit into
Supermonters wants to merge 1 commit into
Conversation
Support --timeout and FILECONV_CONVERT_TIMEOUT_SEC so adversarial convert tests work on macOS without GNU timeout (#366). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #366
Summary
fileconv one/one-detailedvia--timeoutandFILECONV_CONVERT_TIMEOUT_SEC.timeout; core previously had no convert deadline.crates/clionly (2 files). No core/desktop/MCP/server changes.Test plan
cargo fmt --all -- --checkcargo metadata --locked --format-version 1 --no-depspython3 scripts/check-dependency-policy.pycargo test -p fileconv-cli metrics(scoped CI command)cargo test -p fileconv-cli convert_timeout(deterministic break)page-bomb.pdf --timeout 1s→ exit 1 +convert timeout sau 1s--timeout 30s(no hang; page-bomb + long-silence.wav hit 30s)Notes
fileconv-clitests matchingmetrics; timeout unit tests are compile-checked and run locally.