Repository navigation
test: use TEST_TMPDIR as fallback for E2E temporary directory - #34585
Merged
Merged
Conversation
Use Bazel's TEST_TMPDIR when E2E_TEMP is not set so that E2E projects and package caches are created on the main disk inside the Bazel test sandbox rather than /tmp (which is a quota-limited tmpfs on ubuntu-26.04). This also allows reverting E2E CI jobs back to ubuntu-latest.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the mktempd utility function to handle environment variables internally, falling back to process.env.E2E_TEMP, process.env.TEST_TMPDIR, or tmpdir() when tempRoot is not provided. It also simplifies the call to mktempd in tests/e2e_runner.ts. A review comment suggests using the logical OR operator (||) instead of the nullish coalescing operator (??) for environment variables to ensure empty strings are correctly treated as falsy and fall back to the next option.
alan-agius4
added
target: patch
devversion
approved these changes
Oct 29, 2026
alan-agius4
force-pushed
the
test/e2e-test-tmpdir
branch
2 times, most recently
from
October 29, 2026 10:34
2bd3dc6 to
6ade441
Compare
alan-agius4
force-pushed
the
test/e2e-test-tmpdir
branch
6 times, most recently
from
October 29, 2026 14:45
5ef6a0e to
d718bf6
Compare
alan-agius4
force-pushed
the
test/e2e-test-tmpdir
branch
from
October 29, 2026 14:56
d718bf6 to
aff2f78
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Bazel's TEST_TMPDIR when E2E_TEMP is not set so that E2E projects and package caches are created on the main disk inside the Bazel test sandbox rather than /tmp (which is a quota-limited tmpfs on ubuntu-26.04). This also allows reverting E2E CI jobs back to ubuntu-latest.