Repository navigation
ci: enable runfiles when cross-building Windows E2E tests - #34584
Merged
Merged
Conversation
When cross-building the Windows E2E targets on Linux with `--platforms=tools:windows_x64`, `@bazel_lib//lib:enable_runfiles` evaluates to `False` unless `--enable_runfiles` is passed, causing `aspect_rules_js` to generate the test launcher script with `JS_BINARY__NO_RUNFILES=1`. In `aspect_rules_js` 3.5.2, `JS_BINARY__NO_RUNFILES=1` resolves the entry point using `JS_BINARY__BINDIR` (`bazel-out/k8-fastbuild/bin`) instead of `BAZEL_BINDIR` (`.`), which fails on Windows CI where the tests are executed from the built `.runfiles` directory tree. Passing `--enable_runfiles` during the Windows E2E cross-build ensures the launcher script resolves the entry point from the runfiles directory.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
angular-robot
Bot
added
the
area: build & ci
alan-agius4
added
action: review
crisbeto
approved these changes
Oct 29, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross-building the Windows E2E targets on Linux with
--platforms=tools:windows_x64,@bazel_lib//lib:enable_runfilesevaluates toFalseunless--enable_runfilesis passed, causingaspect_rules_jsto generate the test launcher script withJS_BINARY__NO_RUNFILES=1.In
aspect_rules_js3.5.2 (see #34578),JS_BINARY__NO_RUNFILES=1resolves the entry point usingJS_BINARY__BINDIR(bazel-out/k8-fastbuild/bin) instead ofBAZEL_BINDIR(.), which fails on Windows CI where the tests are executed from the built.runfilesdirectory tree. Passing--enable_runfilesduring the Windows E2E cross-build ensures the launcher script resolves the entry point from the runfiles directory.