Repository navigation
fix(@angular/build): quote weak ETags of assets served by the dev server - #34566
Merged
Merged
Conversation
Extensionless, JavaScript, TypeScript and stylesheet assets served by the dev server and the Vitest browser runner sent an unquoted weak ETag such as `W/25a71cd345af2de4`. RFC 9110 requires the entity tag to be quoted (`W/"25a71cd345af2de4"`), which is how the other ETags in the same middleware are already formatted.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the weak ETag generation in the assets middleware to correctly wrap the calculated hash in double quotes, adhering to standard ETag formatting. It also adds a corresponding integration test to verify that extensionless assets are served with a valid weak ETag. There are no review comments, and I have no feedback to provide.
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Oct 28, 2026
alan-agius4
reviewed
Oct 28, 2026
alan-agius4
approved these changes
Oct 28, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensionless, JavaScript, TypeScript and stylesheet assets served by the dev server and the Vitest browser runner sent an unquoted weak ETag such as
W/25a71cd345af2de4. RFC 9110 requires the entity tag to be quoted (W/"25a71cd345af2de4"), which is how the other ETags in the same middleware are already formatted.