Repository navigation
fix(@angular/build): remove every output of a deleted asset in watch mode - #34565
Merged
alan-agius4 merged 2 commits intoOct 28, 2026
Merged
Conversation
…mode The previous asset state was keyed by source file, so an asset copied to several destinations (two asset entries with the same input, or one copy per locale with `localize`) kept only the last destination. Deleting the source during `ng build --watch` then removed only that copy and left the others in the output directory. Key the previous asset state by destination instead.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the asset tracking logic during incremental builds to key previous assets by their destination rather than their source. This ensures that when a single source asset is copied to multiple destinations, all corresponding output files are correctly tracked and removed if the source asset is deleted. A new behavior test has been added to verify this scenario. I have no feedback to provide.
alan-agius4
added
the
target: patch
alan-agius4
reviewed
Oct 28, 2026
alan-agius4
added
the
action: cleanup
alan-agius4
added
action: merge
alan-agius4
approved these changes
Oct 28, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous asset state was keyed by source file, so an asset copied to several destinations (two asset entries with the same input, or one copy per locale with
localize) kept only the last destination. Deleting the source duringng build --watchthen removed only that copy and left the others in the output directory.Key the previous asset state by destination instead.