[thekhegay]

PR Checklist

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

refactor-jasmine-vitest drops .and.callThrough() on spy that already exists and leaves just spy;
Before #33266 that mostly worked since vi.spyOn calls through anyway, now bare spyOn becomes vi.spyOn(...).mockReturnValue(undefined) and spy stays stub after migration, without any TODO

beforeEach(() => {
  api = new Api();
  spy = spyOn(api, 'get');
});

it('calls the real method after callThrough()', () => {
  spy.and.callThrough();
  expect(api.get(1)).toBe('1');
  expect(spy).toHaveBeenCalledWith(1);
});

Passes on Jasmine, after migration ng test fails with AssertionError: expected undefined to be '1' and nothing points to dropped line
Spy that got .and.returnValue('x') first keeps returning 'x' same way

What is the new behavior?

When .and.callThrough() is called on existing spy (spy, getSpy()), it is kept as is with TODO, so converted spec fails right on that line until it is migrated
Vitest has no exact equivalent there, mockReset() brings original implementation back but also clears recorded calls, so TODO sugests it and says that
Chain right on spy creation (spyOn(...).and.callThrough(), same for spyOnProperty and jasmine.createSpy) is removed like before, also when call is wrapped in parens or type assertion

New spec cases for existing spy fail on main (get mySpy; and getSpy();), wrapped spyOn case passes on main and guards new check

Does this PR introduce a breaking change?

• Yes
• No

Other information

I went with TODO since rewrite is not 1:1. If you prefer, it can emit spy.mockReset() directly with "verify" TODO, like arrayWithExactContents-check does
That makes example above pass right after migration, but test that counts calls made before callThrough() fails with expected "get" to be called 2 times, but got 1 times

[gemini-code-assist]

Code Review

This pull request introduces handling for .and.callThrough() on existing spies during the Jasmine-to-Vitest migration, adding a TODO comment instead of dropping it. It also includes corresponding unit tests and TODO notes. The review feedback highlights that the current check !ts.isCallExpression is insufficient because custom helper calls (e.g., getSomeSpy().and.callThrough()) would be incorrectly treated as spy creations and silently dropped. It is recommended to explicitly check for spyOn or spyOnProperty calls and add a test case to cover this scenario.

[alan-agius4]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 01abe08
• 22.2.x: 8c89107