Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces Prettier with oxfmt as the default formatter in the Angular workspace schematics, updating the dependencies, configuration templates, and associated tests. Feedback on the changes highlights that the excludeFiles property in the new .oxfmtrc.json.template is unsupported by oxfmt and will cause configuration parsing to fail, so it should be removed.
3a9b624 to
5faafa7
Compare
|
Thank you for putting this together, @cexbrayat! For the time being, we would like to keep Prettier as the default formatter for newly generated workspaces. We can re-evaluate switching to Closing this PR for now, and we can revisit it in the future! |
|
Thanks for the feedback @alan-agius4 Instead of waiting for a major release, could it be considered to have a |
|
We'd prefer not to introduce a |
|
Understood. I'll ping you when v23 is close to check if it's worth reopening the PR. Thanks Alan. |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The generated projects set up prettier
What is the new behavior?
Now that oxc-project/oxc#17852 is resolved, oxfmt can be used in modern Angular project. This PR replaces the prettier dependency and config by oxfmt
Does this PR introduce a breaking change?
Other information