Repository navigation
058: GO decision — read-only recovery diagnostics (design spike) - #672
Closed
andyrewlee wants to merge 1 commit into
Closed
andyrewlee wants to merge 1 commit into
andyrewlee wants to merge 1 commit into
Conversation
Design spike only — no production changes. The artifacts under plans/spikes/058/ resolve the honest state model: the .deleting tombstone is a boolean marker, so the status dialog can truthfully derive only two states (interrupted-with-live-root vs pending-with-root-gone) plus a log pointer — no stage/error text is fabricated. The durable journal and in-dialog retry are rejected and deferred respectively; the live-root pin and alias-ID fencing belong to finishInterruptedDelete and stay untouched. 14 executable cases pin read-only behavior (every diagnostic case asserts may_mutate=false); implementation.md is the self-contained handoff for a two-bit cleanupPending/cleanupRootPresent probe on the existing off-loop path.
andyrewlee
added a commit
that referenced
this pull request
Sep 28, 2026
Lands the full advisor implementation stack: workspace transactions and lifecycle teardown, git cancellation bounds, durable port reservations with degrade-not-block migration, semantic activity transitions, atomic self-update, visual-row diff scrolling, async project tree, e2e workspace-root isolation, and the storeID-loss + lock-ENOENT regression fix. The plans/ working artifacts are intentionally not committed — they were scaffolding for the work, not product. Supersedes PRs #646-#672.
Owner
Author
|
Superseded — content landed on main via merge 8580442 (plans/ scaffolding intentionally excluded). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design spike for plan 058 — plans-only artifacts, no production changes. Decision: GO for a read-only diagnostic increment; the retry action is deferred.
plans/spikes/058/decision.md— evidence table of every recovery state the code can distinguish, honest state model (the.deletingtombstone is a boolean marker: two derivable states, never fabricated stage/error text), presentation mockups, retry-safety boundary, alternatives, verdictplans/spikes/058/recovery-cases.json— 14 cases; every diagnostic-open assertsmay_mutate=false; includes alias-ID, stale-token, root-reappears, and suppressed-row edgesplans/spikes/058/implementation.md— self-contained handoff:WorkspaceCleanupSnapshot(stat-only, off-loop via the existingworkspaceStatusReadyMsgfence), conditionalcleanup:section, test→case map, STOP conditionsRejected: a structured delete journal (new durable schema to answer what auto-retry already answers) and an in-dialog retry (v1 keeps
iread-only; auto-retry at load already covers every reachable pending state).Test plan
git diff --checkclean