Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two live-test bugs on GCP.
amicu applyon Compute Engine failed with HTTP 411. Operation waits arePOST .../operations/{op}/waitwith no body, and Google's front end rejects that.GcpClient::requestnow sends{}for any POST or PATCH without a body, so reqwest sets Content-Type and Content-Length. Every other POST in the GCP code already sent a body; the two operation waits were the only bodiless ones.amicu destroyandamicu orphanspanicked with "there is no reactor running" when a Cloud Run (or Compute Engine) record was present. The refresh and orphan listing paths built a runtime but created the GCP client, whose credentials spawn a token-cache task, before entering it. They now holdrt.enter()first. The fake GCP client in tests asserts a runtime context exists, so a runtime-less construction fails the destroy, refresh and orphans tests.