Repository navigation
fix(cli): stop auto-updating over a local or dev-channel build - #92
Merged
Merged
Conversation
upgrade.ts only exempted the literal "local" channel from the self-upgrade check. A local build on any other channel — including "dev", the stable default build-local.ts now uses for every local build — was treated as a real release and compared against the latest published version. Confirmed live: a dev build's version read as needing "a patch", and the auto-updater silently curl-installed a real release over the running binary mid-session, corrupting the TUI's rendered screen with the installer's raw progress output and leaving the process spinning afterward. Replace the "local"-only check with InstallationIsRelease (channel is latest/beta/prod — the only channels a real release ever carries, already used by database.ts to pick the session-database path). Comparing a never-published build's version against "the latest release" is meaningless at best; silently replacing it mid-session is actively harmful.
The previous commit replaced upgrade.ts's InstallationLocal check with InstallationIsRelease, dropping the tracked marker string; updated it to match. version.ts is a newly-diverged upstream file (adds InstallationReleaseChannels/InstallationIsRelease) and needed a fresh patched entry.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrade.tsonly exempted the literal"local"channel from the self-upgrade check. A local build on any other channel — including"dev", the stable defaultbuild-local.tsnow uses for every local build — was treated as a real release and compared against the latest published version.Confirmed live: a dev build's version read as needing "a patch", and the auto-updater silently
curl-installed a real release over the running binary mid-session, corrupting the TUI's rendered screen with the installer's raw progress output and leaving the process spinning afterward.Replaces the
"local"-only check withInstallationIsRelease(channel islatest/beta/prod— the only channels a real release ever carries, already used bydatabase.tsto pick the session-database path). Comparing a never-published build's version against "the latest release" is meaningless at best; silently replacing it mid-session is actively harmful.Test plan
bun typecheckclean (core, opencode)packages/core/test/database-migration.test.tspasses (channel-path refactor didn't change behavior for release channels)bun run script/fork-verify.tsclean