Repository navigation
Dynamically fetch available LLM models from providers - #60
Open
mingweiliao wants to merge 1 commit into
Open
mingweiliao wants to merge 1 commit into
mingweiliao wants to merge 1 commit into
Conversation
mingweiliao
force-pushed
the
update-gemini-llm-model-config
branch
from
October 23, 2026 14:50
ae4fe83 to
bd4f213
Compare
utkarsh2827
reviewed
Oct 26, 2026
Contributor
There was a problem hiding this comment.
Is this the right screenshot? I think all screenshots have an error state now?
Contributor
Author
There was a problem hiding this comment.
Ah, this is broken from last PR. Updated the screen shot test to supply state (previously it is included in metadata, we need to change it to read it from separate API)
utkarsh2827
reviewed
Oct 26, 2026
|
|
||
| private var observationJob: Job? = null | ||
|
|
||
| init { |
Contributor
There was a problem hiding this comment.
this has no error handling, so any exception thrown by getAvailableModels kills the coroutine in viewModelScope.
Contributor
Author
There was a problem hiding this comment.
This is expected. getAvailableModel is not supposed to crash but if it does, it should crash the app
- Replace hardcoded LlmModel enum with a serializable data class and Room TypeConverter - Query the Gemini models API for gemini-* models supporting generateContent - Group models by provider in the UI dropdown and handle empty model/thread states when no API key is configured - Fix screenshot test reference image paths and update previews for the no-thread state
mingweiliao
force-pushed
the
update-gemini-llm-model-config
branch
from
October 27, 2026 13:40
bd4f213 to
88454af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
LlmModelenum in the sample agent with dynamic model discovery from configured LLM providers, so newly released models are available automatically without requiring code changes.Key Changes
LlmModelrepresentation:LlmModelfrom a hardcodedenum classto a@Serializable data class LlmModel(val providerName: LlmProviderName, val modelName: String).LlmProvider.getAvailableModels):suspend fun getAvailableModels(apiKey: String?): List<LlmModel>toLlmProvider.GeminiProviderImpl.getAvailableModelsto queryGET https://generativelanguage.googleapis.com/v1beta/models?pageSize=100and filter forgemini-*models supportinggenerateContent.AgentDemoViewModelto fetch available models across providers when API keys change and automatically create an initial thread once models are available.AgentUiState.Loaded.currentThreadnullable so the app loads cleanly instead of staying on the loading spinner when no API key or thread exists yet.ModelDropdowninAgentDemoScreento group models byLlmProviderNameand handle empty model/thread states gracefully.com/example/appfunctionsstudio->com/example/appfunctions/agent) and added/updated previews for loading and no-thread states.getAvailableModelsand updated existing test suites.Test
./gradlew spotlessCheck test validateScreenshotTest./gradlew connectedStandardDebugAndroidTest