Repository navigation
fix: preserve reduced motion with targeted CSS rules - #60
Draft
anchildress1 wants to merge 2 commits into
Draft
anchildress1 wants to merge 2 commits into
anchildress1 wants to merge 2 commits into
Conversation
Generated-by: Codex <noreply@openai.com> Signed-off-by: Ashley Childress <anchildress1@gmail.com>
Generated-by: Codex <noreply@openai.com> Signed-off-by: Ashley Childress <anchildress1@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace four blanket reduced-motion !important overrides with targeted component rules, preserving the static reduced-motion state. Replace two transition: all declarations with the properties that actually change. Add a browser regression for reduced motion.
Initial main inventory: six findings, four addressed by this PR and two retained sequential-await candidates. The exact PR scan also surfaced two new CSS S9449 findings; both are addressed separately from the initial count.
The retained retry await in src/server/queue.ts enforces dependent attempts and 250/500ms backoff. Success or definitive refusal must prevent later attempts; concurrent retries would violate that contract. The retained redraw await in src/server/rerender.ts accepts an unbounded list, including duplicate slugs, and completes each synchronous PNG render plus ordered PNG/payload publication before starting another target. Promise.all would change fail-fast behavior, retain concurrent image buffers, and permit duplicate-slug writes to interleave. The four-connection Snowflake pool does not bound outstanding uploads. Recursion or promise reduction would merely disguise the same sequential work, so neither finding was suppressed or marked resolved.
Validation on final signed head
5fc1872250d761e8bcc038b8f80ce37f23ddb066: make ai-checks passed formatting, lint, typecheck, build and 316 tests with 96.57% line coverage; all nine Playwright tests passed. Normal commit/push hooks and signature verification passed. Exact-head Sonar PR analysis reports zero findings and quality gate OK; Semgrep passed. CI and CodeQL intentionally skip draft PRs under the existing workflow policy; local aggregate/browser verification completed.Main remains unchanged until merge and reanalysis. Zero PR findings does not mean main is zero. No exclusions, suppressions, issue-status changes, or draft-policy changes were used.