Repository navigation
Conversation
Author
|
Heads up on the red CI: the jobs fail at "Set up job" because the workflow still uses Happy to send a separate PR bumping the cache action to v4 if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentRoot::loadMimeFileTypes()truncates any subtype that contains a dot or a plus sign after the first segment. The regex only allows[a-z0-9\-]+with one optional+suffix, so with the bundledresources/mime:xlsapplication/vnd.ms-excelapplication/vnddocxapplication/vnd.openxmlformats-officedocument.wordprocessingml.documentapplication/vndEvery
vnd.*type in the bundled file ends up asapplication/vnd, which makes browsers fall back to generic handling for those downloads.This came out of the fixes I made in my fork (webpatser/fledge-fiber), sending them back upstream as asked. Hope it catches a clean wave.
Summary
[a-z0-9][a-z0-9.+\-]*, so dotted, plus and dash subtypes are kept whole.Test plan
testBundledMimeFileIsParsedInFull: every line of the bundled mime file maps to exactly its listed type (last entry wins for duplicate extensions, matching the parser).testDottedPlusAndDashSubtypesAreNotTruncated:xls,svganddocxresolve to their full types.