Repository navigation
Fix read stall on TLS streams with non-select drivers - #117
Open
kafkiansky wants to merge 1 commit into
Open
kafkiansky wants to merge 1 commit into
kafkiansky wants to merge 1 commit into
Conversation
On a TLS stream feof() checks liveness with SSL_peek(), which moves a record that has just arrived from the socket into the OpenSSL buffer. If that happens between the empty direct read and enabling the watcher, the socket is no longer readable and drivers polling the descriptor (uv, ev, event) never invoke the watcher, so the read waits forever although the data is buffered. StreamSelectDriver is not affected because stream_select() checks SSL_pending(). Read once more after feof() reports the stream is still open.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a TLS stream feof() checks liveness with SSL_peek(), which moves a record that has just arrived from the socket into the OpenSSL buffer. If that happens between the empty direct read and enabling the watcher, the socket is no longer readable and drivers polling the descriptor (uv, ev, event) never invoke the watcher, so the read waits forever although the data is buffered. StreamSelectDriver is not affected because stream_select() checks SSL_pending().
Read once more after feof() reports the stream is still open.