arm64 support - #4
Open
darkdragon-001 wants to merge 1 commit into
Open
Conversation
It fails on arm64 and only succeeds on amd64 because of luck. It is skipped when cross-compiling anyways. Based on the comment, weight_test.cc tests the same functionality but succeeds on arm64, so the autoconf failure is a false negative. Removing this test to fix build for arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove float equality test from configure.ac as it fails on arm64 and only succeeds on amd64 because of luck. It is skipped when cross-compiling anyways.
Based on the comment, weight_test.cc tests the same functionality but succeeds on arm64, so the autoconf failure is a false negative. Removing this test to fix build for arm64.
Testing procedure:
Build and test on arm64 via qemu:
docker buildx build --platform linux/arm64 .This is part of a my effort to enable arm64 builds in vosk: