Skip to content

fix: explain expected reference formats in ref validation errors + omp manifest #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alpertarhan merged 2 commits into from
Sep 7, 2026
Merged

fix: explain expected reference formats in ref validation errors + omp manifest #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8060a39
fix: explain expected reference formats in ref validation errors
alpertarhan Sep 7, 2026
b263a00
feat: declare explicit pi entry and omp extension manifest
alpertarhan Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@
},
"pi": {
"extensions": [
"./extensions"
"./extensions/forgejo/index.ts"
]
},
"omp": {
"extensions": [
"./extensions/forgejo/index.ts"
]
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ export default function forgejoExtension(pi: ExtensionAPI): void {
const value = args.trim();
if (value) {
const ref = parseResourceRef(value);
if (!ref) throw new Error(`invalid Forgejo reference '${value}'`);
if (!ref) throw new Error(`invalid Forgejo reference '${value}' — expected 'server:owner/repo#N' (issue), 'server:owner/repo!N' (pull), 'server:owner/repo' (repo), or 'fj://server/owner/repo/<issue|pull>/<N>'; for git tags/branches use the git_ref parameter`);
const server = current.config.servers[ref.server];
if (!server) throw new Error(`unknown server '${ref.server}'`);
await openExternal(pi, resourceWebUrl(ref, server), server.baseUrl);
Expand Down
7 changes: 5 additions & 2 deletions src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ import type {
ReviewDraft,
} from "./types.js";

const REF_FORMAT_HINT =
"expected 'server:owner/repo#N' (issue), 'server:owner/repo!N' (pull), 'server:owner/repo' (repo), or 'fj://server/owner/repo/<issue|pull>/<N>'; for git tags/branches use the git_ref parameter";

export interface RepoInput {
ref?: string;
server?: string;
Expand Down Expand Up @@ -102,7 +105,7 @@ export class ForgejoRuntime {
if (input.ref) {
const resource = parseResourceRef(input.ref);
if (!resource)
throw new Error(`invalid Forgejo reference '${input.ref}'`);
throw new Error(`invalid Forgejo reference '${input.ref}' — ${REF_FORMAT_HINT}`);
this.clients.get(resource.server);
return {
server: resource.server,
Expand Down Expand Up @@ -139,7 +142,7 @@ export class ForgejoRuntime {
if (input.ref) {
const resource = parseResourceRef(input.ref);
if (!resource)
throw new Error(`invalid Forgejo reference '${input.ref}'`);
throw new Error(`invalid Forgejo reference '${input.ref}' — ${REF_FORMAT_HINT}`);
if (resource.kind !== kind)
throw new Error(`reference '${input.ref}' is not a ${kind}`);
this.clients.get(resource.server);
Expand Down