Repository navigation
fix(docs): correct API contracts and stabilize browser checks - #27
Merged
Merged
Conversation
Follow up on the review of #25. Distinguish awaited and discarded callback Tasks, document headless range-parser and cell-coordinate limitations, and describe decimal conversion bounds and exceptions without promising type preservation. These changes document existing runtime behaviour rather than altering the library. Wait for Mermaid rendering before both keyboard-navigation overflow assertions so the checks do not measure the unrendered diagram source. Validated on 2026-10-19: 21 tooling tests; Astro check with no diagnostics; builds, 718 links and 14 browser tests at both / and /excel/; 20 repeated keyboard-navigation checks; task compile; 46 headless tests; chunk tests on net462 and net10.0 plus the net462 console runner. Real Excel tests were not rerun because the existing Microsoft 365 privacy dialog blocks unattended execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on all five review findings from #25. The documentation overstated callback, range-parsing, cell-coordinate and value-conversion guarantees, and the navigation checks could measure page width before Mermaid finished rendering.
Validation
Completed on 2026-10-19:
npm test: 21 tests passed.npm run check: no errors, warnings or hints.npm run build,npm run check:linksandnpm run test:browserpassed at both/and/excel/: 718 links checked and 14 browser tests passed per deployment path.git diff --checkpassed.task compilepassed. Headless tests: 46 passed. Chunk tests: 11 passed on each of net462 and net10.0, plus 11 passed through the net462 console runner.Real Excel tests were not rerun because the existing Microsoft 365 privacy dialog blocks unattended execution.