Include Thrust tuple and zip iterator headers - #188
Merged
griwodz merged 1 commit intoAug 7, 2026
Conversation
CUDA 13.3 no longer exposes these declarations transitively. Include the headers used by s_filtergrid.cu so thrust::tuple, thrust::make_tuple, and thrust::make_zip_iterator remain available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates src/popsift/s_filtergrid.cu by adding includes for <thrust/iterator/zip_iterator.h> and <thrust/tuple.h>, and removes a trailing newline at the end of the file. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jul 21, 2026
…s upstream build system; worked around this by just updating to a version not from 2022. GPT 5.6 Sol found and fixed a couple of issues which were filed upstream as ezEngine/ezEngine#1991 and ezEngine/ezEngine#1992 . [popsift] More missing headers from CUDA changes. Submitted upstream as alicevision/popsift#188 [mongo-c-driver, opencv4] Apply upstream fixes for CUDA 13.3 and CMake 4.4.
griwodz
self-requested a review
August 7, 2026 06:56
griwodz
approved these changes
Aug 7, 2026
griwodz
left a comment
griwodz
left a comment
Member
There was a problem hiding this comment.
I have verified on Ubuntu that this change is required for CUDA 13 and that it works for CUDA 12 and 13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA 13.3 no longer exposes these declarations transitively. Include the headers used by s_filtergrid.cu so thrust::tuple, thrust::make_tuple, and thrust::make_zip_iterator remain available.
This change authored by GPT 5.6-Sol