feat(doc|cli|review|scan|prompt): add structured category and severity fields to review findings#299
Conversation
|
🔍 OpenCodeReview found 6 issue(s) in this PR.
📄
|
|
feature more, may need support customlized level and category(including definition) in future. |
|
Hi @ScarletCarpet, thank you so much for this contribution — and for taking the time to fork, extend, and polish this feature. The colored badges, client-side filters, normalization, and the accompanying tests are all genuinely appreciated. I want to be transparent about where things stand. There are currently three PRs implementing this same capability — #29, #79, and yours (#299) — and #29 came first. Out of fairness to the original author, we'd like to give #29 a chance to land first. If it doesn't get a response by next week, our team will step in and drive this feature to completion ourselves. I also owe you an apology for the slow turnaround. Please know it isn't a reflection of the quality of your work. The real bottleneck for this feature isn't the coding — it's the evaluation. Getting the severity/category classification to behave consistently and measurably well across real-world reviews requires many rounds of evaluation and iteration. Because of that, it will likely be more efficient for our team to carry it forward directly — it saves a lot of back-and-forth communication overhead during those evaluation cycles. We hope you understand. Thank you again for your patience and for your contribution. 🙏 |
Fully understand. Quality First., just follow your own step. The main goal is to build a more powerfull OCR. |
…y fields to review findings add category and serverity feature which forked from [pr-29](alibaba#29) and add or fix some extra change @mvanhorn: - Use fun call instead of modify system prompt - Add colored severity badge to terminal text output for quick visual scanning - Add --level and --category CLI flags to filter findings at client-side - Normalize severity values: only high, medium, low - Remove `test` category and add `imporvement` category - Sort findings by severity (high -> medium -> low) then by category - Update README (en/zh-CN) with filter flag documentation and examples - Add comprehensive tests for normalization, filtering, sorting, badges
f7e6fa6 to
282279d
Compare
|
all reviews had been fixed. |

add category and serverity feature which forked from pr-29 and add or fix some extra change @mvanhorn:
testcategory and addimporvementcategoryDescription
Type of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues
issue refer to:
#16
#96
original PR refer to:
#29