Repository navigation
Preserve net recipients in transaction CSV destinations - #689
Open
startupcompliancekit wants to merge 1 commit into
Open
startupcompliancekit wants to merge 1 commit into
startupcompliancekit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #537.
Determine change addresses independently for ALPH and each token using the net amount per address. Keep positive-net recipients even when they also appear in the inputs, aggregate repeated outputs, and retain existing amounts and FromAddresses behavior. Include the transaction cited in the issue as an offline fixture.
Validation: 26 tests across two suites passed, including the reported transaction, token overlap, duplicate outputs, unchanged balances and ordinary change. Formatting and lint passed. All seven backend patches also passed 134 tests together.