Repository navigation
Add host field on robot create/edit forms - #3
Merged
Merged
Conversation
petr-airoa
approved these changes
Jun 9, 2026
okubotakuya-airoa
approved these changes
Jun 10, 2026
okubotakuya-airoa
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM!
mark-takada-airoa
force-pushed
the
feat/robot-form-host-field
branch
from
June 10, 2026 23:26
a8ccc4c to
071677e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote
hostfrom the JSONrobot_configblob to a dedicated, required input on the Create/Edit Robot forms, and rebrand the remaining JSON section as "Advanced Settings."Changes
hosttext field (validated viaz.string().min(1)) above the JSON textarea in bothcreate-robot-form.tsxandedit-robot-form.tsx.hostfrom its placeholder; the field now only carriesport,cameras, etc.robot-config-utils.tswithmergeRobotConfigWithHost(merges the dedicated host into the JSON on submit, returnsnullon invalid JSON) andsplitHostFromRobotConfig(extracts host from the stored config when seeding Edit defaults).robotForm.host,robotForm.hostDescription,robotForm.advancedSettings,robotForm.advancedSettingsDescription, andvalidation.hostRequired.Local Verification
Before creating the PR, please verify the following (exclude items already covered by CI/CD):
Create Robot — host required validation
validation.hostRequiredi18n error and blocks submit.robot_config.hostin the API payload.hostkey.Create Robot — Advanced Settings invalid JSON guard
Edit Robot — host preload
robot_confighas ahost, it appears in the Host field on load.{}placeholder).Edit Robot — host overwrite on save
robot_config.hostwith the new value.hostkey inside Advanced Settings, the dedicated Host field still wins on collision.i18n labels (en / ja)
- en: "Host IP", "Advanced Settings (JSON)", and "Host IP is required" render correctly.