fix(cmake): find python for pybind11 without the removed module - #89
Open
EnriqueParodi wants to merge 1 commit into
Open
fix(cmake): find python for pybind11 without the removed module#89EnriqueParodi wants to merge 1 commit into
EnriqueParodi wants to merge 1 commit into
Conversation
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 18, 2026 23:15
a02cecb to
ea320c0
Compare
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 18, 2026 23:15
83f14ce to
0271e1b
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 18, 2026 23:19
ea320c0 to
58567b7
Compare
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
2 times, most recently
from
August 18, 2026 23:47
a9d1f56 to
3dec10d
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 18, 2026 23:47
58567b7 to
2a8df5f
Compare
EnriqueParodi
marked this pull request as ready for review
August 19, 2026 00:06
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 19, 2026 07:42
3dec10d to
bc1ae1f
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 19, 2026 07:42
2a8df5f to
2aba493
Compare
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 19, 2026 12:18
bc1ae1f to
0e90241
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 19, 2026 12:18
2aba493 to
e9b221b
Compare
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 19, 2026 12:41
0e90241 to
36b6204
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 19, 2026 12:41
e9b221b to
8f01f06
Compare
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 19, 2026 21:21
36b6204 to
aa31bb4
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 19, 2026 21:21
8f01f06 to
813b575
Compare
pybind11 looks for Python through FindPythonLibs unless told otherwise, and CMake 3.27 deprecated that module; pinning CMP0148 to OLD only delays the break. PYBIND11_FINDPYTHON sends it to FindPython, and the hint keeps it on the interpreter this project already found.
EnriqueParodi
force-pushed
the
test/rest-flaky-default-config
branch
from
August 20, 2026 11:26
aa31bb4 to
e8d7c13
Compare
EnriqueParodi
force-pushed
the
fix/pybind11-python-discovery
branch
from
August 20, 2026 11:26
813b575 to
6f6ca05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pybind11 looks for Python through FindPythonLibs unless told otherwise, and CMake
3.27 deprecated that module; pinning CMP0148 to OLD only delays the break and
warns twice on every configure. PYBIND11_FINDPYTHON sends it to FindPython, and
the hint keeps it on the interpreter this project already found.